Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify and reenable testcases related to Backport for JDK-8311964: x86 bug 'unrecognized VM options' (C2 flags) #5011

Open
adamfarley opened this issue Jan 29, 2024 · 8 comments

Comments

@adamfarley
Copy link
Contributor

adamfarley commented Jan 29, 2024

Summary

An upstream bug has been seen in JDK21 (and under) testing at Adoptium.

To solve this, we should request that the fix for that bug be backported.

Details

Adoptium test failures were documented here and here.

These tests were subsequently excluded here.

These failures look like they were caused by this OpenJDK bug.

We see that this bug has been fixed, and that the fix was merged into JDK22+.

To solve this problem at Adoptium, a backport was proposed in the General Retrospective for the Adoptium January 2024 releases.

@adamfarley adamfarley changed the title Backport JDK-8311964: x86 bug 'unrecognized VM options' (C2 flags) Backport Request for JDK-8311964: x86 bug 'unrecognized VM options' (C2 flags) Jan 29, 2024
@adamfarley
Copy link
Contributor Author

Thanks Shelley :)

@jiekang
Copy link
Contributor

jiekang commented Mar 6, 2024

Backport has been made to 21u and 17u by sendaoYan in February, see issue comments in link below:

https://bugs.openjdk.org/browse/JDK-8311964

@smlambert
Copy link
Contributor

Changing the title to reflect the action now is to check that the test cases can be re-included.
related: #4965

@smlambert smlambert changed the title Backport Request for JDK-8311964: x86 bug 'unrecognized VM options' (C2 flags) Verify and reenable testcases related to Backport for JDK-8311964: x86 bug 'unrecognized VM options' (C2 flags) Mar 6, 2024
@jiekang
Copy link
Contributor

jiekang commented Mar 6, 2024

Noting for future investigator, the OpenJDK PR only mentions three tests:

Following tests were affected:
TestInfiniteLoopWithUnmergedBackedgesMain.java - Affected by 'LoopUnswitching'
TestBackedgeLoadArrayFillMain.java - Affected by 'OptimizeFill'
TestRangeCheckCmpUOverflowVsSub.java - Affected by 'StressCCP'

@jiekang
Copy link
Contributor

jiekang commented Mar 6, 2024

Also just further checked, the PRs to backport have been opened but not approved or merged. Sorry.

openjdk/jdk21u-dev#279
openjdk/jdk17u-dev#2216

@sendaoYan
Copy link
Contributor

Also just further checked, the PRs to backport have been opened but not approved or merged. Sorry.

openjdk/jdk21u-dev#279 openjdk/jdk17u-dev#2216

I will try to backport there two PRs as soon as quick possible.

@jiekang
Copy link
Contributor

jiekang commented Mar 12, 2024

@sendaoYan

Ah, thank you for the update. And thanks for doing the work to backport those changes!

I did not mean to suggest they need to be done immediately. When you have time to do them is great!

@sendaoYan
Copy link
Contributor

@sendaoYan

Ah, thank you for the update. And thanks for doing the work to backport those changes!

I did not mean to suggest they need to be done immediately. When you have time to do them is great!

OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Status: Todo
Development

No branches or pull requests

4 participants