Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ProblemList_openjdk**-openj9.txt to openj9 | ibm folder. #5835

Open
sophia-guo opened this issue Dec 23, 2024 · 1 comment
Open

Comments

@sophia-guo
Copy link
Contributor

sophia-guo commented Dec 23, 2024

Vendor specific ProblemLists (excludes/vendors/vendor/ProblemList_openjdk*.txt) is used for handling vendor specific features . Common temporary problemlists stays in openjdk/excludes/ProblemList_openjdk*.txt.

Currently openj9|IBM problemlists is an exception, which has a different name for problemlist. Most of the exclusions in problemlist is duplicated in openj9 problemlist. And when re-enable both files need to be updated.

Suggest to refactor those files. Move openj9 problemlist to openj9|ibm as a vendor folder. Renaming the "-openj9" problemlist as normal ones. Removing all duplicate exclusions in openj9 problemlist.

This can eliminate the redundancy, ease the maintenance, improve the consistency and make openj9 problemlist simple and clear to its own issues.

@sophia-guo
Copy link
Contributor Author

openj9 sdk has following properties
"-DJDK_IMPL=openj9" "-DJDK_VENDOR=eclipse"
"-DJDK_IMPL=openj9" "-DJDK_VENDOR=ibm"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant