Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust release tool to show yellow status when releaseCheck.sh shows error condition #3064

Closed
sxa opened this issue Aug 10, 2022 · 2 comments
Closed

Adjust release tool to show yellow status when releaseCheck.sh shows error condition #3064

sxa opened this issue Aug 10, 2022 · 2 comments
Assignees
@andrew-m-leonard
Labels
enhancement Issues that enhance the code or documentation of the repo in any way

Comments

@sxa
Copy link
Member

sxa commented Aug 10, 2022

releaseCheck.sh is executed in the refactor_openjdk_release_tool job. At the moment if it fails the checks it's only visible when looking in the console log. We should modify the execution of the job so that it can return a warning status back to the publish job so it will show as a yellow status if the checks fail.
@sxa sxa added the enhancement Issues that enhance the code or documentation of the repo in any way label Aug 10, 2022
@sxa sxa mentioned this issue Aug 10, 2022
Open
11 tasks
@jiekang
Copy link
Contributor

jiekang commented Aug 24, 2022

RFE: Clearly state the success or failure in the console log for the entire check in a single string

@adamfarley adamfarley mentioned this issue Aug 2, 2023
Closed
11 tasks
@andrew-m-leonard andrew-m-leonard self-assigned this Sep 5, 2023
@andrew-m-leonard andrew-m-leonard mentioned this issue Sep 5, 2023
Merged
@andrew-m-leonard
Copy link
Contributor

Fixed: adoptium/github-release-scripts#136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-m-leonard andrew-m-leonard

Labels
enhancement Issues that enhance the code or documentation of the repo in any way
Projects
No open projects
Adoptium 3Q 2023 Plan
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jiekang @sxa @andrew-m-leonard