Add an uniq id for characters + full character object in dialogue

[jrmgx]

On the client side we need to rely on a unique character id for some feature
this change will affect both plays and play/[*]/act/[*] endpoints in multiple places

It will allow us to have a better support on the LBG play

The id must be unique on a specific play, there is no other constrain IMHO

Plan

• Add a unique character id in the plays endpoint

[{
  "id": "fourberies",
  "title": "Les Fourberies de Scapin",
  "illustrationFile": "/play/fourberies/illustration.png",
  "characters": [{
    "identifier": "argante",
    "name": "ARGANTE",
    "desc": "père d’Octave et de Zerbinette.",
    "avatarFile": "/play/fourberies/avatars/argante.png"
  }

• Add a unique character id in the play/*/act/* endpoint on the characters listing part

{
  "title": "Le Bourgeois gentilhomme",
  "characters": [{
    "identifier": "monsieur-jourdain",
    "name": "MONSIEUR JOURDAIN",
    "desc": "bourgeois."
  }]

• Add a full character reference in the play/*/act/* endpoint on the dialogue part
  This include a clear separation between the character and the information on his sentence
  (in this example "MAÎTRE DE MUSIQUE parlant à ses Musiciens") has been moved to an action field

"dialogue": [{
  "character": {
    "identifier": "maintre-de-musique",
    "name": "MAÎTRE DE MUSIQUE"
  },
  "action": "MAÎTRE DE MUSIQUE parlant à ses Musiciens",
  "text": "Venez, entrez dans cette salle, et vous reposez là, en attendant qu’il vienne.",
  "textWithEmoji": "Venez, entrez dans cette salle, et vous reposez là, en attendant qu’il vienne.",
  "emojiWords": { }
}

If this issue is not clear let's talk more about it

[adrienjoly]

ahah! t'es au taquet, jérôme! ^^

[jrmgx]

Il faut que je note les trucs sinon ça m'occupe la tête pour rien :)

[adrienjoly]

GTD style! tu as raison!

[adrienjoly]

Why do you need unique ids for characters?

[jrmgx]

it is mainly to group bubbles by characters
it is also used to know if it is the character you selected that is talking or not

[adrienjoly]

Well, names are unique too in the scope of a play, no?

Le mer. 3 août 2016 18:43, Jérôme Gangneux notifications@github.com a
écrit :

it is mainly to group bubbles by characters
it is also used to know if it is the character you selected that is
talking or not

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgdRb6GJ7wFxidB3HibTpbSCAk7_4Tdks5qcJjMgaJpZM4JV9YG
.

Adrien Joly
adrienjoly.com

[jrmgx]

nop because of other information that comes with the name
like "MONSIEUR JOURDAIN, l'épé à la main" or anything else.
If you can make sure that a name is really a name it will work (as you say)

[adrienjoly]

ok. will it work better for you if I store only the name in the character
field, and other indications (e.g. l'épée à la main) in an indications
field ?

On Thu, Aug 4, 2016 at 9:41 AM Jérôme Gangneux notifications@github.com
wrote:

nop because of other information that comes with the name
like "MONSIEUR JOURDAIN, l'épé à la main" or anything else.
If you can make sure that a name is really a name it will work (as you say)

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgdRQBm_mhfqPVSNxNwT0T-RxaU5Rg8ks5qcZe6gaJpZM4JV9YG
.

Adrien Joly
adrienjoly.com

[jrmgx]

will be great