Exception generated in base.py when empty tags are manipulated as if they were strings #153
Labels
bug
Something isn't working
Comments
seasidesparrow
added a commit
to seasidesparrow/ADSIngestParser
that referenced
this issue
Dec 16, 2024
modified: adsingestp/parsers/base.py new file: tests/stubdata/input/jats_empty_smallcaps_tag_apj_976_1_119.xml new file: tests/stubdata/output/jats_empty_smallcaps_tag_apj_976_1_119.json modified: tests/test_jats.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Parsing the JATS file
/proj/ads/abstracts/data/IOPP/2024-11-19/0004-637X/0004-637X_976/0004-637X_976_1/0004-637X_976_1_119/apj_976_1_119.xmlyields an exception because of a<sc/>tag in the abstract. base.py applies a modification to anything tagged as small caps by using.upper(), but in the case of an empty tag, it is trying to apply upper case to NoneType.To Reproduce
Steps to reproduce the behavior:
Additional context
This can be fixed by checking for the existence of e.string in
base.pyL592, and only then apply.upper()ife.stringis notNone.The text was updated successfully, but these errors were encountered: