forked from mdaines/viz-js
-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
global exception handler being added that causes gnarly stack traces #32
Comments
I'd send in a PR for this but I honestly don't quite know where the linker step is in the Makefile so am unsure where this makes sense |
Alright, created a PR that locally worked as expected. Would definitely appreciate a merge + a release of this change, as right now my stack traces are very hard to read without this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This library's emscriptem code sets up an
uncaughtException
listener at the top level if it is imported.This handler will re-throw the error, causing the logging to print the exception source line as the minified single line of the project. So importing this library and then having an error will cause a big
^ you can see the issue running this in node. The stack trace just dumps the entire file.
This seems to be related to emscripten-core/emscripten#17228 and this specific part of the source
From that issue:
So I think if the configuration adds those two parameters then this library will no longer include that exception handler.
The text was updated successfully, but these errors were encountered: