Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable network ID and include it in transaction data binaries when signing #750

Open
d-velev opened this issue Nov 7, 2018 · 2 comments

Comments

@d-velev
Copy link
Contributor

d-velev commented Nov 7, 2018

The network ID is appended to the transaction data that is being signed, meaning that transactions made in one network aren't going to be valid in another. It should be "ae_mainnet" by default

@Artur64
Copy link
Contributor

Artur64 commented Nov 12, 2018

@d-velev Could you provide a link to get more information about this?

@d-velev
Copy link
Contributor Author

d-velev commented Nov 12, 2018

@Artur64 I'm not sure where their signing is happening but this is how they transform their transaction binaries https://github.com/aeternity/epoch/blob/master/apps/aecore/src/aec_governance.erl#L217. So we must sign "ae_mainnet" <> serialized_tx and verify the same way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants