Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret name inconsistency #257

Closed
steveoh opened this issue Apr 13, 2023 · 2 comments
Closed

Secret name inconsistency #257

steveoh opened this issue Apr 13, 2023 · 2 comments
Assignees

Comments

@steveoh
Copy link
Member

steveoh commented Apr 13, 2023

if secret_folder.exists():
return json.loads(
Path("/secrets/app/secrets.prod.json").read_text(encoding="utf-8")
)
#: Otherwise, try to load a local copy for local development
secret_folder = Path(__file__).parent / "secrets"
if secret_folder.exists():
#: staging
# return json.loads((secret_folder / "secrets.json").read_text(encoding="utf-8"))
#: prod
return json.loads(
(secret_folder / "secrets.prod.json").read_text(encoding="utf-8")

This is referencing your secret mount incorrectly

/secrets/app/secrets.json=${{inputs.project_id}}/skid-secrets

Your secret is mounted as /secrets/app/secrets.json

@steveoh steveoh changed the title Secret name is inconsistency Secret name inconsistency Apr 13, 2023
@stdavis
Copy link
Member

stdavis commented Apr 13, 2023

Good catch. Thanks.

@stdavis
Copy link
Member

stdavis commented Apr 29, 2024

This has been fixed.

@stdavis stdavis closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants