Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization #67

Closed
nathankota opened this issue Jul 15, 2021 · 7 comments
Closed

Internationalization #67

nathankota opened this issue Jul 15, 2021 · 7 comments
Assignees

Comments

@nathankota
Copy link

Make the app accessible for Spanish speakers/readers.

@stdavis
Copy link
Member

stdavis commented Nov 28, 2023

Just an FYI. I used GitHub Copilot to generate the translations. So there is no guarantee that they are perfect.

@steveoh
Copy link
Member

steveoh commented Nov 28, 2023

Should we double check them with google translate or run them by someone at the state?

@stdavis
Copy link
Member

stdavis commented Nov 28, 2023

I believe that Nathan said that DNR had someone that would take a look at them. You can see them all in this file: https://github.com/agrc/roadkill-mobile/blob/staging/src/front/services/translations.json

@nathankota
Copy link
Author

Will ask DWR to review all translations.

Found the following areas where translation is missing:

My Reports

Image

Profile

Image

About

Image

Logout

Image

Report > common name

Image

Report > family

Image

@stdavis stdavis assigned stdavis and unassigned nathankota Jan 3, 2024
stdavis added a commit that referenced this issue Jan 3, 2024
@stdavis stdavis removed their assignment Jan 3, 2024
@stdavis
Copy link
Member

stdavis commented Jan 3, 2024

I just pushed an update to staging that addresses these issues: v3.0.7 (636). Thanks for the review, @nathankota !

@stdavis
Copy link
Member

stdavis commented Jan 3, 2024

From Jessica today:

I got the spanish reviewed!

Here are the comments from the reviewer:
The translations look great to me, however there were two lines in need of some attention. In lines 245 and 263 the word "Carcasa" should be changed to "Cuerpo." The word "cuerpo" means "carcass," but I noticed that in lines 377 and 378 the word "cadaver" is used. The word "cadaver" means corpse, I think the translation is correct, but it is worth noting that these two words can be interchangeable and may confuse some users.

@nathankota
Copy link
Author

implemented in v3.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants