make BlockingPortal.stop sync #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
make-blocking-portal-stop-sync
branch
from
d77d139
to
e0ff495
Compare
graingert
force-pushed
the
make-blocking-portal-stop-sync
branch
from
e0ff495
to
2adff23
Compare
agronholm
requested changes
Jul 4, 2021
There was a problem hiding this comment.
If this method is made synchronous, we need to ensure that people dont try to use it from external threads. At the very least, a warning against that should be added to the docstring. The event.set() call should raise a clear enough error but I feel that the event loop thread id member set should be moved to after the event set, to be safe.
agronholm
reviewed
Jul 5, 2021
src/anyio/from_thread.py
Outdated
Comment on lines
158
to
159
| self._stop_event.set() | ||
| self._event_loop_thread_id = None |
There was a problem hiding this comment.
This should avoid breakage when called from external threads.
Suggested change
| self._stop_event.set() | |
| self._event_loop_thread_id = None | |
| if self._event_loop_thread_id is None: | |
| return | |
| if threading.get_ident() != self._event_loop_thread_id: | |
| raise RuntimeError('This method must be called from the event loop thread') | |
| self._event_loop_thread_id = None | |
| self._stop_event.set() |
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
graingert
commented
Jul 5, 2021
| @@ -154,11 +155,18 @@ async def stop(self, cancel_remaining: bool = False) -> None: | |||
| finish before returning | |||
|
|
|||
| """ | |||
| if self._event_loop_thread_id is None: | |||
There was a problem hiding this comment.
ah this is wrong - we need to handle cancel_remaining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.