-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Youtube embed not rendering in Safari #191
Comments
Oh wow, thank you so much @Amartya for finding this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Details
Steps to reproduce
As you can see, the the src parameter is set without the protocol string (https).
This works fine in Chrome (106.0.5249.103) and Firefox (v 105.0.3)
I know this is a bug report, but in case it helps, I made the following changes to the mdx_video.py file
In the extendMarkdown function, I changed the regular expression to capture the protocol along with the youtubeid parameter. So the code was change from
r"([^(]|^)https?://www\.youtube\.com/watch\?\S*v=(?P<youtubeid>\S[^&/]+)"
TO
r"([^(]|^)(?P<protocol>(https?))://www\.youtube\.com/watch\?\S*v=(?P<youtubeid>\S[^&/]+)"
In the Youtube class, I changed the code from
TO the version below that just uses the protocol parameter
Finally, thank you so much for your work/plugin. It has been incredibly helpful. If you take pull requests, I'd be happy to make the changes for your review.
The text was updated successfully, but these errors were encountered: