forked from CasperWA/voila-optimade-client
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy import of pandas #19
Comments
I'll just note that the next big offender is I suspect (but did not verify) that this is due to pydantic models. I wonder if using the |
Okay, cool! Let's do pandas first. BTW, the performance test by @superstar54 was did with old aiida-core 2.4 without your performance improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a low-hanging fruit for speeding up the import of
ipyoptimade
package.pandas
is currently imported only insrc/ipyoptimade/subwidgets/output_summary.py
I've already done the same in AWB, so this win should directly translate into faster app load speed. (locally I see ~200ms difference, would probably be bigger in the Demo container).
cc @superstar54 @unkcpz
For reference, I benchmark the import time with
To get this
The text was updated successfully, but these errors were encountered: