Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching mechanism does not distinguish HubbardStructureData from StructureData #1015

Open
mikibonacci opened this issue Mar 16, 2024 · 2 comments

Comments

@mikibonacci
Copy link
Contributor

It seems that the caching mechanism does not distinguish HubbardStructureData from standard StructureData.
The very same simulation but changing the structure to be HubbardStructureData is considered identical to the original one, and so if caching is enabled this causes problems.

I guess there is just a check on the attributes of StructureData.

Pinning @bastonero and @mbercx: do you have comments on this? is it a known issue?

@bastonero
Copy link
Collaborator

Interesting, indeed I don't know how it generates the hash. Maybe we can simply store an attribute in the constructor, but isn't it an issue of aiida-core that does not distinguish two different class entry-points?

@sphuber
Copy link
Contributor

sphuber commented Mar 17, 2024

This is indeed a bug in aiida-core: aiidateam/aiida-core#6320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants