Entering an invalid coupon code in the basket checkout page causes the "Checkout" button to disappear

[Physikbuddha]

Entering an invalid coupon code in the basket checkout page causes the "Checkout" button to disappear.

Before entering the code:

After entering the code:

This is because the template at aimeos/ai-client-html/templates/client/html/basket/standard/body.php performs an additional check about whether to show the button or not. To make the button appear, the view's property standardCheckout must be set to true:

This property is set in aimeos/ai-client-html/src/Client/Html/Basket/Standard/Standard.php in line 141. However this line will never be reached if an invalid coupon code is entered, as like 108 will throw an exception in that case, so the control flow goes straight to line 146 in the catch block:

[aimeos]

Maybe moving the "check" block to a finally block may solve that issue?

try
{
	switch( $view->param( 'b_action' ) )
	{
		case 'add':
			$this->addProducts( $view );
			break;
		case 'coupon-delete':
			$this->deleteCoupon( $view );
			break;
		case 'delete':
			$this->deleteProducts( $view );
			break;
		case 'save':
			$this->saveBasket( $view );
			break;
		default:
			$this->updateProducts( $view );
			$this->addCoupon( $view );
	}
}
catch( \Exception $e )
{
	$controller->save();
	throw $e;
}
finally
{
	$check = (int) $view->config( 'client/html/basket/standard/check', 1 );

	switch( $check )
	{
		case 2: if( $view->param( 'b_check', 0 ) == 0 ) { break; }
		case 1: $controller->get()->check( ['order/product'] );
		default: $view->standardCheckout = true;
	}
}

[Physikbuddha]

In theory it should work, unless the code moved to finally can cause some exceptions as well. But these methods seem to be rather small and well-tested ($view->config(), $view->param()), so it looks like a feasible solution.

[aimeos]

The check() method throws an exception if the basket content isn't valid for checkout but then, the checkout button shouldn't be shown anyway. The change is now available in this commit: cf7fb21 (also available for 2024.10.x-dev)