-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] App is crashing if you use CompatibleAnimationView in xib/storyboard #2161
Comments
@Saratsin, are you interested in making a PR to fix this? That would be much appreciated! Perhaps this init needs to be made public? https://github.com/airbnb/lottie-ios/blob/master/Sources/Public/iOS/Compatibility/CompatibleAnimationView.swift#L196C1-L198C4 If not, could you share a sample Xcode project that demonstrates the error? |
Sure, I can create a PR with fix for it. Do I have to update version to |
If you share a sample xcode project to demonstrate the error you can just point to 4.2.0. If you want to fix the error and then validate that the sample project now works correctly you'd need to edit the code locally, in the cocoapod checkouts. |
@Saratsin, are you able to share a sample project that demonstrates this issue? |
@calda sorry for the delay, here's a sample project with the reproduction of this issue: Lottie-Issue-2161. You just need to build the solution, and you will receive this error in output: |
Which Version of Lottie are you using?
Lottie 4.2.0 - iOS
Steps to reproduce
UIView
element the main xib file or storyboard, change its type toCompatibleAnimationView
Expected Behavior
App is launching and shows the main screen without a problems
Actual Behavior
App is launching and crashes on the main screen:
Reason:
Actually it is described in the exception message.
CompatibleAnimationView
doesn't implement requiredinit
methodThe text was updated successfully, but these errors were encountered: