Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support connection pooling within Client #99

Open
letmutx opened this issue Jan 26, 2020 · 2 comments
Open

Support connection pooling within Client #99

letmutx opened this issue Jan 26, 2020 · 2 comments

Comments

@letmutx
Copy link
Collaborator

letmutx commented Jan 26, 2020

After #97 lands, it'll be nice to have connection pools to prevent threads from connection starvation. Client should support connection pooling behind a feature flag.

Right now, we have r2d2-memcache for this, but it creates Client instances instead of Connection objects which is inefficient if Client contains multiple Connections.

@aisk
Copy link
Owner

aisk commented Jan 29, 2020

I am collaborator of r2d2-memcache, feel free if you willing to modify it.

And for other feature requests, I just have one suggest is that we can learn from https://github.com/mitsuhiko/redis-rs , I think it have more users and have better experimented maitainers.

For now redis-rs have no pooling in client, but seems they had a plan: https://github.com/mitsuhiko/redis-rs/tree/92dcf0820bff731ec48543e8e11854cbf2c55504#basic-operation . So I think we can support this feature. What do you think? @lemutx

@leptonyu
Copy link

leptonyu commented Apr 9, 2021

I think it's better to export single connection management for users, connection pool customization is required. For current implementation using r2d2 is too limited and cannot even use r2d2's full functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants