-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Deepsource with open source components #1305
Comments
not sure if using wrappers like prospector is a good idea for us. Keeping it modular for the moment. |
what are your doubts? |
I got scared after running it locally within a pre-commit hook. Pylint seems to be too pedantic about issues where none exist. |
not sure how to run trivy: https://github.com/aquasecurity/trivy |
also probably overkill to run with every test.. |
I just want to remind you that this task is assigned to me. As far as I know you can disable pylint with:
And each tool can be configured separately. see https://prospector.landscape.io/en/latest/profiles.html |
But you doubts let me thing about the advantages of using prospector other than having one single config-file? Maybe we can really spare it. |
Deepsource seems to be running now, but I would still progress in replacing it with open-source tools. |
sorry, I thought I can do it as it requires removing all of the deepsource comments and creation of stages in the jenkinsfile. Please review the changes when I open the PR. |
got mypy, bandit and flake8 tests in the Jenkins CI and also extended the pre-commit hook, notably with PEP257 checks with docformatter. There are also quite some changes to the format of docstrings.. |
Following modules should be included in the CI-Pipeline:
Whitelisting comments must be replaced with the ones from the new components.
The text was updated successfully, but these errors were encountered: