-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change persistence handling to standardize saving dictionaries as json in JsonUtil.encode_object #557
Comments
Idea: use the old pull request to create a concept of persisting data and adapt it at a per class basis. |
Also change persistence after creating new unittests - wait before a major release. |
ToDo after unittests for the analysis classes are created - always also check the persisted data format on disk. These are breaking changes and need to be done before a new release. |
save ETD data as dictionary. |
#300 is related. |
I think there will never be a good opportunity to implement this this issue, because these would be breaking changes for existing deployments. There could be an automatic tool to update existing persisted data, but it might not be worth the implementation time and risks involved. The benefits simply do not outweight the risks and hassle. @landauermax do you agree? |
Yes I agree, it is high risk and not worth it just for the sake of standardization. |
For example like in the EFD:
for log_ev, freq in self.counts_prev.items():
persist_data.append((log_ev, freq))
The text was updated successfully, but these errors were encountered: