Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnalysisChild persistency handling for unix sockets #605

Open
landauermax opened this issue Apr 2, 2021 · 2 comments
Open

AnalysisChild persistency handling for unix sockets #605

landauermax opened this issue Apr 2, 2021 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@landauermax
Copy link
Contributor

When logs are received from a unix socket, starting from a specific line never makes sense (in fact, it produces unexpected behavior that is difficult to debug and find the cause). To avoid this situation altogether, the AnalysisChild (in particular, the resposioning_data) should (i) not be read/used when the logstream is a unix socket, and (ii) should not be persisted in intervals or when terminating the aminer.

@landauermax landauermax added the bug Something isn't working label Apr 2, 2021
@ernstleierzopf
Copy link
Contributor

ernstleierzopf commented Apr 6, 2021

Currently there is no issue in the code. In line 450 of the AnalysisChild the UnixSocketLogDataResource is initialized. The repositioning data is never given as a parameter and also the LogStream.UnixSocketLogDataResource does nothing with the repositioning_data parameter.

It is true that repositioning_data is saved, however in the next cycle it is again deleted without being used.

Please reopen if something is wrong with my explanation.

@whotwagner whotwagner self-assigned this Apr 6, 2021
@whotwagner
Copy link
Contributor

I reopened this issue because we do have a very strange behavior when we read from the unix-domain-socket and we have to fix that somehow. I assigned the issue to me because I have to locate the problem first and in order to do this a special testing-environment is needed.

@ernstleierzopf ernstleierzopf removed their assignment Apr 18, 2021
@4cti0nfi9ure 4cti0nfi9ure added this to the 2.4.1 milestone Jun 25, 2021
@whotwagner whotwagner modified the milestones: 2.4.1, 2.4.2 Jul 27, 2021
@4cti0nfi9ure 4cti0nfi9ure modified the milestones: 2.4.2, V2.5.1 Nov 24, 2021
@whotwagner whotwagner modified the milestones: 2.5.1, 2.6.0 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants