Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching braces highlighting does not remove previous brace highlighting on new brace selection #2918

Closed
chrissimpkins opened this issue Mar 3, 2016 · 4 comments

Comments

@chrissimpkins
Copy link

We are using ace.js v1.2.3 via cdnjs on the Font Playground site (https://sourcefoundry.org/hack/playground.html) and a user reported a matching braces highlighting issue with the following behavior:

  • selection of a left brace appropriately matches and highlights the closing right brace
  • selection of a new left brace appropriately highlights the matching right brace but the previously matched / highlighted right brace remains highlighted.

It was reported by a user in sf-web/sf-web.github.io#9 on Ubuntu 14.04 with the Chromium browser and I can verify that it also occurs on OS X 10.10.5 in Firefox 46.0a2 (2016-03-02).

Any thoughts?

cc:@jublo

@nightwing
Copy link
Member

looks like you have same session attached to two different editors.

@chrissimpkins
Copy link
Author

@nightwing Thank you very much for the rapid response Harutyun. I am assuming that this is coming from the side-by-side editor display approach that we are using? We do have two editors implemented on the page.

Is it possible to disable the brace matching feature? The goal here is the display of code + syntax highlighting with the various typefaces, not to edit code.

cc: @burodepeper

@nightwing
Copy link
Member

Sessions shared that way are going to cause other problems too. you can create two editors and set same value to both of them.

@chrissimpkins
Copy link
Author

Thank you very much for your help. I greatly appreciate it. It looks like this is an issue on our end. Will close this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants