Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Segment at end causes endless loop of playing and pausing #1859

Closed
Christopher-Hayes opened this issue Sep 22, 2023 · 5 comments
Closed

Comments

@Christopher-Hayes
Copy link

Christopher-Hayes commented Sep 22, 2023

SponsorBlock correctly skips the segment. But, something about the segment ending when the video ends, causes the video to then play and pause repeatedly until I seek somewhere else in the video.

I'm seeing it on this video: https://www.youtube.com/watch?v=WefPAy2lqrA

The video is 11:09.941 in length. (Checked with <video>.duration)
There's an "Unpaid/Self Promotion" segment from 10:37.207 to 11:09.941.

Video of bug

trimmed_output.webm

Versions

Version: 5.4.20
Browser: Firefox 118.0b9

Didn't find any other issues that sounded like this. The only ones that sounded remotely similar were #1409 and #1240. But, those are more related to looping.

@Sopor
Copy link

Sopor commented Sep 27, 2023

I was going to report the same and it was before i even submitted the segment:

sponsorblock_loop.mp4

@mchangrh
Copy link
Contributor

mchangrh commented Oct 1, 2023

#1818 #1409 #1240 and discord

something about segments not reaching the very end of the video and looping when attempting to skip

@ajayyy
Copy link
Owner

ajayyy commented Oct 18, 2023

I believe this will be fixed by c8c141f

@ajayyy ajayyy closed this as completed Oct 18, 2023
@Sopor
Copy link

Sopor commented Oct 19, 2023

I believe this will be fixed by c8c141f

@ajayyy I'm running version 5.4.24 of SB and do that version contain this fix?

I'm getting a similar issue that i haven't seen before, so i wanted to know before reopen/open an issue.

@ajayyy
Copy link
Owner

ajayyy commented Oct 19, 2023

@Sopor no, I haven't released it yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants