Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: support client-managed healthchecks (livenessProbe, readinessProbe) and imagePullPolicy #85

Open
andy108369 opened this issue Mar 31, 2023 · 2 comments
Labels
P2 repo/provider Akash provider-services repo issues

Comments

@andy108369
Copy link
Contributor

andy108369 commented Mar 31, 2023

This would solve one of the important use-cases - a self-updating image through livenessProbe.

With the livenessProbe pointed to query the releases link comparing against the current version would allow it to fail once there is a new image available, causing the pod restart allowing it to self-update. This requires imagePullPolicy: Always set for this specific deployment.

Add client-managed healthchecks (livenessProbe, readinessProbe and their parameters) and setting imagePullPolicy to Always.

Refs
https://discord.com/channels/747885925232672829/1090670585555730563/1091261402729156608
akash-network/provider#54
#50
https://github.com/arno01/self-update


PoC

  • Dockerfile
FROM nginx
RUN echo ver1 > /usr/share/nginx/html/index.html
  • pod.yaml
---
apiVersion: v1
kind: Pod
metadata:
  name: pod1
spec:
  containers:
  - name: container1
    #image: nginx
    image: andrey01/testimage
    imagePullPolicy: Always
    livenessProbe:
      httpGet:
        path: /health2
        port: 80
      initialDelaySeconds: 5
      periodSeconds: 10
      timeoutSeconds: 15
@troian troian removed their assignment Mar 31, 2023
@bmenzalji
Copy link

@anilmurty would this be a good experiment for us to create a bounty for the community. Currently, this is needed for Pre-Search.

Andy has more info on it, and link attached to the convo in our discord channel with them.

@anilmurty
Copy link

potentially but first we need to clean up the local dev env set up (readme on the github repo) for node and provider repos, so that others can get set up (we did this for console before engaging OSS dev community)

@troian troian added repo/provider Akash provider-services repo issues P2 and removed awaiting-triage labels Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 repo/provider Akash provider-services repo issues
Projects
None yet
Development

No branches or pull requests

4 participants