Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 v2.0.0 #12

Closed
alankan886 opened this issue Mar 13, 2021 · 0 comments
Closed

🔖 v2.0.0 #12

alankan886 opened this issue Mar 13, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@alankan886
Copy link
Owner

alankan886 commented Mar 13, 2021

After speaking with @blazej-czapp and receiving useful feedback, I'm looking to push out a new version that's simpler and more user-friendly.

To toss off the over-engineered code, my main goals are:

  1. Keeping the class attributes simple (i.e. no previous and current values)
  2. Adding review(quality, review_date) function and keeping first_review(quality, review_date), removing everything else.
  3. Allowing the user to input date as a string with format Year-Month-Day and other common formats.

The flow of using the package when pulling data from the database would be:

from supermemo2 import SMTwo
# first review
review = SMTwo.first_review(quality, review_date)

# after first review
# your read data from db for your existing values
# new review
# returns an SMTwo object with the new values
review = SMTwo(easiness, interval, repetitions).review(quality, review_date)
@alankan886 alankan886 self-assigned this Mar 13, 2021
@alankan886 alankan886 added the enhancement New feature or request label Mar 13, 2021
@alankan886 alankan886 pinned this issue Mar 13, 2021
@alankan886 alankan886 mentioned this issue Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant