Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for instagram embeds #22

Open
dawaltconley opened this issue Aug 12, 2021 · 0 comments
Open

Add support for instagram embeds #22

dawaltconley opened this issue Aug 12, 2021 · 0 comments

Comments

@dawaltconley
Copy link

I'd be interested in submitting a pull request to support instagram embeds.

Those are a little trickier in that they require a script tag, which you usually don't want more than one of per-page. As part of that / allowing people more control over the output HTML I'd like to also submit a pull request exposing the function that converts urls to their embeddable versions to the user. Something like this

var embed = require('embed-video');
embed.url(/* youtu.be url */) // returns youtube.com/embed url

Though there may be better ways to handle that, and it may be useful to also return the video "type" ('youtube', 'vimeo', etc) in some cases.

Let me know if either / both would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant