-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False negatives in header/footer test #29
Comments
This is due to the rendering differences from phantomjs. On linux it seems as though the pdf created has text in it and on osx it is just a big image - ariya/phantomjs#10373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As I mentioned in #28 this test was failing even before my modifications and since it's breaking the build of my pull request I decide to dig around a little.
The error is triggered by these two lines:
I've inspected the the temporary PDF files generated during the test with
evince
and bothSome Header
andSome Footer
are clearly present in the result. So it looks like the current test for header/footer started throwing false negatives.I've tried finding the dependency that caused this change by downgrading both node and some of the packages to the ones used in the successful build without success. But since I am not aware of an automated way to perform such checks I ended up doing it manually so it's possible that I missed a package.
The text was updated successfully, but these errors were encountered: