Example Parallel Request Amp

[dhodo15]

I already check the example of Parallel Request Amp and now i want a little bit different.

  /**
   * @param WriteRegisterRequest[] $requests
   */
private function requestWithAmp($requests)
    {
        $promises = [];
        foreach ($requests as $request) {

            $promises[] = \Amp\call(function () use ($request) {
                /** @var \Amp\Socket\Socket $socket */
                $socket = yield connect($request->getUri());
                try {
                    yield $socket->write($request);

                    $data = b'';
                    // How to handle response after write event??
                } catch (\Exception $e) {
                    echo $e->getMessage() . PHP_EOL;
                } finally {
                    $socket->close();
                }

                return null;
            });
        }

        try {
            // will run multiple request in parallel using non-blocking php stream io
            $responses = \Amp\Promise\wait(\Amp\Promise\all($promises));
            print_r($responses);
        } catch (\Throwable $e) {
            print_r($e);
        }
    }

as you can see, i have confuse to handle response. Hope you help me to deal with this.

[aldas]

you are missing this block

modbus-tcp-client/examples/example_parallel_requests_amp.php

Lines 66 to 74 in 436d85d

	while (null !== $chunk = yield $socket->read()) {
	// there are rare cases when MODBUS packet is received by multiple fragmented TCP packets and it could
	// take PHP multiple reads from stream to get full packet. So we concatenate data and check if all that
	// we have received makes a complete modbus packet.
	// NB: `Packet::isCompleteLength` is suitable only for modbus TCP packets
	$data .= $chunk;
	if (Packet::isCompleteLength($data)) {
	return $request->parse($data);
	}

in case of write request. You still need to parse response. In parse ($request->parse($data)) method this is done.

        $response = ResponseFactory::parseResponse($binaryData)->withStartAddress($this->request->getStartAddress());
        if ($response instanceof ErrorResponse) {
            return $response;
        }

you could do

                $data = b'';
                while (null !== $chunk = yield $socket->read()) {
                    // there are rare cases when MODBUS packet is received by multiple fragmented TCP packets and it could
                    // take PHP multiple reads from stream to get full packet. So we concatenate data and check if all that
                    // we have received makes a complete modbus packet.
                    // NB: `Packet::isCompleteLength` is suitable only for modbus TCP packets
                    $data .= $chunk;
                    if (Packet::isCompleteLength($data)) {
                        return ResponseFactory::parseResponse($data)->withStartAddress($this->request->getStartAddress());
//                        return ResponseFactory::parseResponseOrThrow($data)->withStartAddress($this->request->getStartAddress());
                    }
                }

[dhodo15]

in my case, i never reach packet complete length == true and its make infinite loop. thats why i remove it. I have try your suggestion and still the same.

this is my data sample

array(12) {
  [0]=>
  array(4) {
    ["uri"]=>
    string(22) "tcp://10.27.59.247:502"
    ["type"]=>
    string(5) "int16"
    ["address"]=>
    int(62)
    ["value"]=>
    int(216)
  }
  [1]=>
  array(4) {
    ["uri"]=>
    string(21) "tcp://10.27.57.11:502"
    ["type"]=>
    string(5) "int16"
    ["address"]=>
    int(62)
    ["value"]=>
    int(170)
  }
  [2]=>
  array(4) {
    ["uri"]=>
    string(21) "tcp://10.27.51.16:502"
    ["type"]=>
    string(5) "int16"
    ["address"]=>
    int(62)
    ["value"]=>
    int(0)
  }
  [3]=>
  array(4) {
    ["uri"]=>
    string(22) "tcp://10.27.62.247:502"
    ["type"]=>
    string(5) "int16"
    ["address"]=>
    int(62)
    ["value"]=>
    int(0)
  }
  [4]=>
  array(4) {
    ["uri"]=>
    string(22) "tcp://10.27.56.247:502"
    ["type"]=>
    string(5) "int16"
    ["address"]=>
    int(62)
    ["value"]=>
    int(145)
  }
  [5]=>
  array(4) {
    ["uri"]=>
    string(22) "tcp://10.27.52.130:502"
    ["type"]=>
    string(5) "int16"
    ["address"]=>
    int(62)
    ["value"]=>
    int(246)
  }
  [6]=>
  array(4) {
    ["uri"]=>
    string(22) "tcp://10.27.59.242:502"
    ["type"]=>
    string(5) "int16"
    ["address"]=>
    int(62)
    ["value"]=>
    int(0)
  }
  [7]=>
  array(4) {
    ["uri"]=>
    string(22) "tcp://10.27.50.243:502"
    ["type"]=>
    string(5) "int16"
    ["address"]=>
    int(62)
    ["value"]=>
    int(0)
  }
  [8]=>
  array(4) {
    ["uri"]=>
    string(22) "tcp://10.27.54.239:502"
    ["type"]=>
    string(5) "int16"
    ["address"]=>
    int(62)
    ["value"]=>
    int(374)
  }
  [9]=>
  array(4) {
    ["uri"]=>
    string(22) "tcp://10.27.54.247:502"
    ["type"]=>
    string(5) "int16"
    ["address"]=>
    int(62)
    ["value"]=>
    int(219)
  }
  [10]=>
  array(4) {
    ["uri"]=>
    string(22) "tcp://10.27.53.247:502"
    ["type"]=>
    string(5) "int16"
    ["address"]=>
    int(62)
    ["value"]=>
    int(0)
  }
  [11]=>
  array(4) {
    ["uri"]=>
    string(22) "tcp://10.27.55.239:502"
    ["type"]=>
    string(5) "int16"
    ["address"]=>
    int(62)
    ["value"]=>
    int(229)
  }
}

am i miss something ?