-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
METRIC/IMPERIAL trouble series: ALT, CALT, VOSC and PCO #9
Labels
Comments
alex-hhh
added a commit
that referenced
this issue
Nov 5, 2022
New "altitude" and "corrected-altitude" series now track altitude in the selected measurement unit (meters or feet), the "alt" and "calt" series remain in meters only, for other calculations. This makes the elevation plot use the correct values when the user has the Imperial units selected.
The altitude/corrected altitude series is now fixed, PCO and VOSC still have this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following series are always kept in metric mode: "alt", "calt", "vosc", "pco" (maybe others?) so all the plots use metric values. See [1] for the meaning of these series.
Summary values (e.g lap average) are displayed as imperial when that system is selected.
Trouble is that summary data when detecting various intervals (intervals.rkt) is expecting them to be always in metric (as the summary values are actually converted for imperial for display). We need to do something similar to the way we handle distance and speed ("dst" -- always metric, "distance" -- metric or imperial; "spd" -- always metric, "speed" -- metric or imperial)
[1] https://github.com/alex-hhh/ActivityLog2/blob/master/doc/session-df.md
The text was updated successfully, but these errors were encountered: