-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature to download by hash from any available services #53
Comments
Dear psifertex, Good afternoon. The idea is good, but we have reservations. For example, we already receive a proposal of using malwoverview for scanning directories recursively, but we didn't accept it because people would use it as an AV, and that is not the idea. Anyway, we will consider it and soon we return a comment about it. The pathlib.Path is an option, and we only need to assure that it will work in any case. Thank you for your message and have a good day. |
I'm happy to write the code myself as I mentioned before, just didn't want to submit something you wouldn't be interested in. |
Jordan, good morning. Ok, let's move on with your proposal. To coordinate things, let's establish a baseline:
This topic 4 would be an idea for the future, and would be very similar to your aggregator, but only presenting the malware classification and eventually indicating whether or not the download is available. If everything is ok and reasonable for you, let me know, and welcome to the team. Have a great day, Jordan. Alexandre. |
That sounds perfect. I'll probably implement only the downloader initially as that scratches my particular itch but I will keep the fourth item in mind so that any changes I make wouldn't conflict with a future feature like that. |
Hi Jordan, Good evening. That's perfect. Please, pay attention to two aspects:
Welcome to the team, and I hope you are doing and in a good health. |
My primary use-case for malwoverview would be to download a hash by name from whatever services had it available. I'd love to have an option to simply provide the sha256 and have the script try all services for which I have API keys included until a download is found. Is this a feature you'd consider accepting a PR for or adding yourself?
Unrelated (happy to file a separate issue but don't want to spam you with too many requests!): have you considered using pathlib.Path so you don't have to do things like https://github.com/alexandreborges/malwoverview/blob/master/malwoverview/malwoverview.py#L68-L74 ?
The text was updated successfully, but these errors were encountered: