Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different behaviour between React - others #12

Open
samouss opened this issue Jul 2, 2018 · 1 comment
Open

Different behaviour between React - others #12

samouss opened this issue Jul 2, 2018 · 1 comment

Comments

@samouss
Copy link
Contributor

samouss commented Jul 2, 2018

On the React implementation when no results are found the refinements applied in the refinement list are removed. It's because we unmount the widget when there is no results. But in React InstantSearch when we unmount a widget we also remove the refinement applied with it. We can hide them in case of no results rather than unmount them completely.

Reproduction

  • Select one or multiple values in the refinement list
  • Search for a query without results → dsdsdsds
  • Remove the search
  • The refinements are gone (with React)

InstantSearch

vanilla

React InstantSearch

react

@Haroenv
Copy link
Contributor

Haroenv commented Jul 2, 2018

It probably should not be unmounted indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants