From 7bfdc05b266c152ccd282462374e49b8715d145a Mon Sep 17 00:00:00 2001
From: Bob Chen <beef9999@qq.com>
Date: Sat, 13 Jan 2024 17:53:19 +0800
Subject: [PATCH] Treat compiler warning as error

---
 CMakeLists.txt                      | 2 +-
 examples/CMakeLists.txt             | 2 ++
 net/basic_socket.cpp                | 2 +-
 net/http/headers.cpp                | 3 +++
 net/http/url.cpp                    | 2 +-
 net/security-context/tls-stream.cpp | 3 +++
 thread/thread.cpp                   | 8 ++++----
 7 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index b92e2c5d..51dfc566 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -46,7 +46,7 @@ endif ()
 ProcessorCount(NumCPU)
 
 # Compiler options
-add_compile_options(-Wall)  # -Werror is not enable yet
+add_compile_options(-Wall -Werror)
 
 set(CMAKE_CXX_STANDARD ${PHOTON_CXX_STANDARD})
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
diff --git a/examples/CMakeLists.txt b/examples/CMakeLists.txt
index 5c8b91e4..b0cc4a1e 100644
--- a/examples/CMakeLists.txt
+++ b/examples/CMakeLists.txt
@@ -1,3 +1,5 @@
+add_definitions(-w)
+
 add_executable(simple-example simple/simple.cpp)
 target_link_libraries(simple-example PRIVATE photon_static)
 
diff --git a/net/basic_socket.cpp b/net/basic_socket.cpp
index 8446b8dd..5b5e8ac3 100644
--- a/net/basic_socket.cpp
+++ b/net/basic_socket.cpp
@@ -284,7 +284,7 @@ ssize_t ISocketStream::recv_at_least_mutable(struct iovec *iov, int iovcnt,
         if (ret == 0) break;    // EOF
         if ((n += ret) >= least) break;
         auto r = v.extract_front(ret);
-        assert(r == ret); (void)r;
+        assert((ssize_t) r == ret); (void)r;
     } while (v.iovcnt && v.iov->iov_len);
     return n;
 }
diff --git a/net/http/headers.cpp b/net/http/headers.cpp
index 39f262e4..9bb3b383 100644
--- a/net/http/headers.cpp
+++ b/net/http/headers.cpp
@@ -146,7 +146,10 @@ HeadersBase::KV* HeadersBase::kv_add_sort(KV kv) {
     if ((char*)(begin - 1) <= m_buf + m_buf_size)
         LOG_ERROR_RETURN(ENOBUFS, nullptr, "no buffer");
     auto it = std::lower_bound(begin, kv_end(), kv, HA(this));
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wclass-memaccess"
     memmove(begin - 1, begin, sizeof(KV) * (it - begin));
+#pragma GCC diagnostic pop
     m_kv_size++;
     *(it - 1) = kv;
     return it - 1;
diff --git a/net/http/url.cpp b/net/http/url.cpp
index 0c66f5f6..e5a534a6 100644
--- a/net/http/url.cpp
+++ b/net/http/url.cpp
@@ -27,7 +27,7 @@ void URL::fix_target() {
     if (m_target.size() == 0 || t.front() != '/') {
         m_tmp_target = (char*)malloc(m_target.size() + 1);
         m_tmp_target[0] = '/';
-        strncpy(m_tmp_target+1, t.data(), t.size());
+        memcpy(m_tmp_target+1, t.data(), t.size());
         m_target = rstring_view16(0, m_target.size()+1);
         m_path = rstring_view16(0, m_path.size()+1);
     }
diff --git a/net/security-context/tls-stream.cpp b/net/security-context/tls-stream.cpp
index dc3ffc59..ad12e61e 100644
--- a/net/security-context/tls-stream.cpp
+++ b/net/security-context/tls-stream.cpp
@@ -101,6 +101,8 @@ class TLSContextImpl : public TLSContext {
             case TLSVersion::SSL23:
                 method = SSLv23_method();
                 break;
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
             case TLSVersion::TLS11:
                 method = TLSv1_1_method();
                 break;
@@ -109,6 +111,7 @@ class TLSContextImpl : public TLSContext {
                 break;
             default:
                 method = TLSv1_2_method();
+#pragma GCC diagnostic pop
         }
         ctx = SSL_CTX_new(method);
         if (ctx == nullptr) {
diff --git a/thread/thread.cpp b/thread/thread.cpp
index f9f1a67e..9ddcd274 100644
--- a/thread/thread.cpp
+++ b/thread/thread.cpp
@@ -928,15 +928,15 @@ R"(
         size_t randomizer = (rand() % 32) * (1024 + 8);
         stack_size = align_up(randomizer + stack_size + sizeof(thread), PAGE_SIZE);
         char* ptr = (char*)photon_thread_alloc(stack_size);
-        auto p = ptr + stack_size - sizeof(thread) - randomizer;
-        (uint64_t&)p &= ~63;
-        auto th = new (p) thread;
+        uint64_t p = (uint64_t) ptr + stack_size - sizeof(thread) - randomizer;
+        p = align_down(p, 64);
+        auto th = new((char*) p) thread;
         th->buf = ptr;
         th->stackful_alloc_top = ptr;
         th->start = start;
         th->stack_size = stack_size;
         th->arg = arg;
-        auto sp = align_down((uint64_t)p - reserved_space, 64);
+        auto sp = align_down(p - reserved_space, 64);
         th->stack.init((void*)sp, &_photon_thread_stub, th);
         AtomicRunQ arq(rq);
         th->vcpu = arq.vcpu;