From f97ac8f06a2ab4734e2a50d443a7b3f9bfcf9c39 Mon Sep 17 00:00:00 2001 From: Bob Chen Date: Mon, 4 Dec 2023 10:03:22 +0800 Subject: [PATCH] Fix the va_args order of http header (#286) --- fs/httpfs/httpfs.cpp | 4 +++- fs/httpfs/httpfs_v2.cpp | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/httpfs/httpfs.cpp b/fs/httpfs/httpfs.cpp index 4ef3e207..511332d3 100644 --- a/fs/httpfs/httpfs.cpp +++ b/fs/httpfs/httpfs.cpp @@ -251,7 +251,9 @@ class HttpFile : public fs::VirtualReadOnlyFile { } void add_header(va_list args) { - common_header[va_arg(args, const char*)] = va_arg(args, const char*); + auto k = va_arg(args, const char*); + auto v = va_arg(args, const char*); + common_header[k] = v; } void add_url_param(va_list args) { url_param = va_arg(args, const char*); } diff --git a/fs/httpfs/httpfs_v2.cpp b/fs/httpfs/httpfs_v2.cpp index 5aaff947..3aa3d881 100644 --- a/fs/httpfs/httpfs_v2.cpp +++ b/fs/httpfs/httpfs_v2.cpp @@ -230,7 +230,9 @@ class HttpFile_v2 : public fs::VirtualReadOnlyFile { //TODO: 这里是否需要考虑m_common_header被打爆的问题? void add_header(va_list args) { - m_common_header.insert(va_arg(args, const char*), va_arg(args, const char*)); + auto k = va_arg(args, const char*); + auto v = va_arg(args, const char*); + m_common_header.insert(k, v); } void add_url_param(va_list args) { m_url_param = va_arg(args, const char*); }