Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify whether Sink#to_json is needed #238

Open
yunfengzhou-hub opened this issue Sep 18, 2023 · 0 comments
Open

Identify whether Sink#to_json is needed #238

yunfengzhou-hub opened this issue Sep 18, 2023 · 0 comments
Labels
type:improvement improvement to existing functionality

Comments

@yunfengzhou-hub
Copy link
Collaborator

Currently, Sink#to_json is not used in production or test code. We need to make sure whether this method is useful. If so, we need to add test cases to verify the correctness of these methods. If not, we should remove this method.
@yunfengzhou-hub yunfengzhou-hub added priority:major type:improvement improvement to existing functionality and removed priority:major labels Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:improvement improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yunfengzhou-hub