Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useInfiniteScroll): compatibility issues of getScrollTop in Android browsers #2285

Merged
merged 3 commits into from
Aug 27, 2023

Conversation

LJJCherry
Copy link
Contributor

@LJJCherry LJJCherry commented Aug 7, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve: #2283

💡 Background and solution

Compatibility issues with Android browsers,document.documentElement.scrollTop return 0
316bd65-eaf9-4441-a285-4c346e5bd001

📝 Changelog

Language Changelog
🇺🇸 English fix(useInfiniteScroll): compatibility issues of getScrollTop in Android browsers
🇨🇳 Chinese fix(useInfiniteScroll): getScrollTop 在安卓浏览器中的兼容性问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ LJJCherry
❌ ljjcherryli


ljjcherryli seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@LJJCherry LJJCherry marked this pull request as draft August 7, 2023 12:14
@LJJCherry LJJCherry marked this pull request as ready for review August 7, 2023 12:14
@LJJCherry LJJCherry changed the title Feature/fix get scroll top [useInfiniteScroll] fix getScrollTop Aug 7, 2023
@LJJCherry LJJCherry changed the title [useInfiniteScroll] fix getScrollTop fix[useInfiniteScroll] getScrollTop error Aug 7, 2023
@liuyib liuyib changed the title fix[useInfiniteScroll] getScrollTop error fix(useInfiniteScroll): compatibility Issues of getScrollTop in Android Browsers Aug 8, 2023
@liuyib liuyib changed the title fix(useInfiniteScroll): compatibility Issues of getScrollTop in Android Browsers fix(useInfiniteScroll): compatibility Issues of getScrollTop in Android browsers Aug 8, 2023
@liuyib liuyib changed the title fix(useInfiniteScroll): compatibility Issues of getScrollTop in Android browsers fix(useInfiniteScroll): compatibility issues of getScrollTop in Android browsers Aug 8, 2023
@crazylxr crazylxr merged commit 5412bb7 into alibaba:master Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useInfiniteScroll 的getScrollTop方法问题
5 participants