Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object.keys observes value changes #6

Open
aleclarson opened this issue Aug 25, 2019 · 1 comment
Open

Object.keys observes value changes #6

aleclarson opened this issue Aug 25, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@aleclarson
Copy link
Collaborator

aleclarson commented Aug 25, 2019 •
edited
Loading

Ideally, the Object.keys shim should only observe key changes (eg: when a key is added or removed). Currently, it observes value changes too (eg: when a key is set to a new value).

Note: This goes for Map.prototype.keys as well.
@aleclarson aleclarson added the bug Something isn't working label Aug 25, 2019
@aleclarson
Copy link
Collaborator Author

Q: Should using Object.keys on an array observe its length or its sparse indices? Probably the latter, since that's what affects the result of Object.keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aleclarson