From 62f6e1a666bd17d54b1d1ce5f47caed533a681b4 Mon Sep 17 00:00:00 2001 From: vladupshot <154623109+vladupshot@users.noreply.github.com> Date: Fri, 29 Dec 2023 16:14:06 +1300 Subject: [PATCH] deploy task def --- .github/workflows/deploy_aws_staging.yml | 25 ++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/.github/workflows/deploy_aws_staging.yml b/.github/workflows/deploy_aws_staging.yml index d70819f..99f94ea 100644 --- a/.github/workflows/deploy_aws_staging.yml +++ b/.github/workflows/deploy_aws_staging.yml @@ -33,17 +33,17 @@ jobs: id: login-ecr uses: aws-actions/amazon-ecr-login@v1 - - name: Build, tag, and push image to Amazon ECR - id: compute-node-build-image - env: - ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }} - ECR_REPOSITORY: upshot-compute-node-staging - IMAGE_TAG: ${{ github.sha }} - run: | - # Build a docker container and push it to ECR so that it can be deployed to ECS. - docker build -f docker/Dockerfile --build-arg ghcr_token=${{ secrets.GHCR_TOKEN }} -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG . - docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG - echo "image=$ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG" >> "$GITHUB_OUTPUT" + # - name: Build, tag, and push image to Amazon ECR + # id: compute-node-build-image + # env: + # ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }} + # ECR_REPOSITORY: upshot-compute-node-staging + # IMAGE_TAG: ${{ github.sha }} + # run: | + # # Build a docker container and push it to ECR so that it can be deployed to ECS. + # docker build -f docker/Dockerfile --build-arg ghcr_token=${{ secrets.GHCR_TOKEN }} -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG . + # docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG + # echo "image=$ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG" >> "$GITHUB_OUTPUT" - name: Fill in the new image ID in the Amazon ECS task definition id: compute-node-task-def @@ -51,7 +51,8 @@ jobs: with: task-definition: infra/staging-task-def.json container-name: upshot-compute-node - image: ${{ steps.compute-node-build-image.outputs.image }} + image: some/image + # ${{ steps.compute-node-build-image.outputs.image }} - name: upshot-compute-node - Deploy Amazon ECS task definition uses: aws-actions/amazon-ecs-deploy-task-definition@v1