Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Derek/ora 481 remove strict dependency between appchain and compute node 1 #30

Conversation

dmikey
Copy link
Contributor

@dmikey dmikey commented Jan 25, 2024

let's remove the sibling dependency, this uses the protocol-state-module that's currently in the upshot-appchain

@dmikey dmikey requested review from xmariachi and Maelkum January 25, 2024 19:15
Copy link

linear bot commented Jan 25, 2024

ORA-481 Remove strict dependency between appchain and compute node

Data scientists should not have to be bothered with all the devops involved in running the appchain. They should just have to worry about their model. However our appchain and compute node are currently coupled in our docker-compose. This shouldn't be the case!

Task here is to split these apart! And also communicate it with the team so minimal surprises. See this convo for more.

Copy link
Contributor

@Maelkum Maelkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused by the title - I thought this would enable us to run the node without having a chain to connect to..?

This to me looks like it just changes where the dependency is pulled from when compiling?

Anyways, codewise looks good!

README.md Show resolved Hide resolved
@dmikey dmikey merged commit 7b37e0e into main Jan 25, 2024
1 check passed
@dmikey dmikey deleted the derek/ora-481-remove-strict-dependency-between-appchain-and-compute-node-1 branch January 25, 2024 19:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants