From 0033888017c377183523aba7df030701b3019e3c Mon Sep 17 00:00:00 2001
From: Francois-Gomis <francois.gomis@getalma.eu>
Date: Mon, 18 Nov 2024 14:31:21 +0100
Subject: [PATCH 1/4] fix : dynamic properties

---
 Model/AlmaPlanDataProvider.php          |  5 +++++
 Model/Resolver/AlmaPlaceOrderOutput.php | 17 +++++++++++++++++
 2 files changed, 22 insertions(+)

diff --git a/Model/AlmaPlanDataProvider.php b/Model/AlmaPlanDataProvider.php
index 711ccca..977b807 100644
--- a/Model/AlmaPlanDataProvider.php
+++ b/Model/AlmaPlanDataProvider.php
@@ -11,6 +11,11 @@
  */
 class AlmaPlanDataProvider implements AdditionalDataProviderInterface
 {
+    /**
+     * @var Logger
+     */
+    private $logger;
+
     public function __construct(
         Logger $logger
     ) {
diff --git a/Model/Resolver/AlmaPlaceOrderOutput.php b/Model/Resolver/AlmaPlaceOrderOutput.php
index a1913df..927535b 100644
--- a/Model/Resolver/AlmaPlaceOrderOutput.php
+++ b/Model/Resolver/AlmaPlaceOrderOutput.php
@@ -13,6 +13,23 @@
 
 class AlmaPlaceOrderOutput implements ResolverInterface
 {
+    /**
+     * @var Logger
+     */
+    private $logger;
+    /**
+     * @var Eligibility
+     */
+    private $eligibility;
+    /**
+     * @var Payment
+     */
+    private $almaPayment;
+    /**
+     * @var OrderFactory
+     */
+    private $orderFactory;
+
     public function __construct(
         Logger $logger,
         Eligibility $eligibility,

From 27410bfc77f93800f5741d9986930c86694ea134 Mon Sep 17 00:00:00 2001
From: Francois-Gomis <francois.gomis@getalma.eu>
Date: Mon, 18 Nov 2024 14:34:45 +0100
Subject: [PATCH 2/4] chore : bump version 0.3.3

---
 CHANGELOG.md  | 4 ++++
 composer.json | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index bad359b..f30e5d1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,10 @@
 CHANGELOG
 =========
 
+v0.3.3
+------
+* Deprecated Functionality: Creation of dynamic property
+
 v0.3.2
 ------
 * remove payment plan deferred_type and deferred_duration
diff --git a/composer.json b/composer.json
index a64b88f..4599b47 100644
--- a/composer.json
+++ b/composer.json
@@ -7,7 +7,7 @@
         "magento/module-sales-graph-ql": ">=100.3.0"
     },
     "type": "magento2-module",
-    "version": "0.3.2",
+    "version": "0.3.3",
     "license": [
         "MIT"
     ],

From 817d909185d063d25e878a2dac4604a720ed21b0 Mon Sep 17 00:00:00 2001
From: Francois-Gomis <francois.gomis@getalma.eu>
Date: Mon, 18 Nov 2024 15:24:19 +0100
Subject: [PATCH 3/4] fix : remove not used property

---
 Model/Resolver/AlmaPlaceOrderOutput.php | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/Model/Resolver/AlmaPlaceOrderOutput.php b/Model/Resolver/AlmaPlaceOrderOutput.php
index 927535b..1062d91 100644
--- a/Model/Resolver/AlmaPlaceOrderOutput.php
+++ b/Model/Resolver/AlmaPlaceOrderOutput.php
@@ -1,4 +1,5 @@
 <?php
+
 namespace Alma\GraphQL\Model\Resolver;
 
 use Magento\Framework\GraphQl\Config\Element\Field;
@@ -6,7 +7,6 @@
 use Magento\Framework\GraphQl\Query\ResolverInterface;
 use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
 use Alma\MonthlyPayments\Helpers\Logger;
-use Alma\MonthlyPayments\Helpers\Eligibility;
 use Alma\MonthlyPayments\Model\Api\Payment;
 
 use Magento\Sales\Model\OrderFactory;
@@ -17,10 +17,6 @@ class AlmaPlaceOrderOutput implements ResolverInterface
      * @var Logger
      */
     private $logger;
-    /**
-     * @var Eligibility
-     */
-    private $eligibility;
     /**
      * @var Payment
      */
@@ -31,13 +27,11 @@ class AlmaPlaceOrderOutput implements ResolverInterface
     private $orderFactory;
 
     public function __construct(
-        Logger $logger,
-        Eligibility $eligibility,
+        Logger       $logger,
         OrderFactory $orderFactory,
-        Payment $almaPayment
+        Payment      $almaPayment
     ) {
         $this->logger = $logger;
-        $this->eligibility = $eligibility;
         $this->almaPayment = $almaPayment;
         $this->orderFactory = $orderFactory;
     }
@@ -52,11 +46,11 @@ public function __construct(
      * @throws GraphQlInputException
      */
     public function resolve(
-        Field $field,
-              $context,
+        Field       $field,
+                    $context,
         ResolveInfo $info,
-        array $value = null,
-        array $args = null
+        array       $value = null,
+        array       $args = null
     ) {
 
         $orderModel = $this->orderFactory->create();
@@ -64,7 +58,7 @@ public function resolve(
         $orderId = $order->getId();
 
         $url = $this->almaPayment->getPaymentUrl($orderId);
-        $this->logger->info('$url',[$url]);
+        $this->logger->info('$url', [$url]);
         return $url;
     }
 }

From 12cf95d64bd004a173e3d258b594653a268d045c Mon Sep 17 00:00:00 2001
From: Francois-Gomis <francois.gomis@getalma.eu>
Date: Mon, 18 Nov 2024 15:25:28 +0100
Subject: [PATCH 4/4] fix : Changelog

---
 CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index f30e5d1..1649dca 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,7 +3,7 @@ CHANGELOG
 
 v0.3.3
 ------
-* Deprecated Functionality: Creation of dynamic property
+* Fix Deprecated Functionality: Creation of dynamic property
 
 v0.3.2
 ------