Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code related to sending EventLog to Splunk #2378

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

mike29736
Copy link
Contributor

https://trello.com/c/Zp23Kd6c/274-remove-functionality-to-send-event-log-to-splunk

[...] we’re now very confident this data has only ever been sent from
integration and even that was some years ago.

> [...] we’re now very confident this data has only ever been sent from
> integration and even that was some years ago.
https://trello.com/c/Zp23Kd6c/274-remove-functionality-to-send-event-log-to-splunk
Copy link
Contributor

@floehopper floehopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might also be able to remove the faraday gem...?

Otherwise this looks good to me 👍

@floehopper floehopper self-assigned this Sep 27, 2023
We've just removed the only code in the app that used this.

It was only being used for sending EventLogs to Splunk. Or at least, by
the code that was intended to send EventLogs to Splunk, but hadn't sent
any for a few years.
@mike29736 mike29736 merged commit 591bfe2 into main Sep 27, 2023
6 checks passed
@mike29736 mike29736 deleted the remove-splunk branch September 27, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants