Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latin verb with mood=gerundive matches whitaker mood=participle #608

Closed
balmas opened this issue Jan 11, 2021 · 5 comments
Closed

Latin verb with mood=gerundive matches whitaker mood=participle #608

balmas opened this issue Jan 11, 2021 · 5 comments
Labels
bug Something isn't working verified

Comments

@balmas
Copy link
Member

balmas commented Jan 11, 2021

another interesting point here, which @rgorman helped clarify -- the treebank reports this as mood=gerundive. The Whitake parser used by Alpheios reports all Gerunds as verb participles (see alpheios-project/morphsvc#11).

I think perhaps we should make a change to the Alpheios treebank adapter to consider a Latin verb with mood=gerundive as being the same as a verb participle. That way we will at least be comparing apples to apples. We'd still have a disconnect here, because the tense in the treebank is present. But we would at least be matching the part of speech.

Originally posted by @balmas in #540 (comment)

@balmas
Copy link
Member Author

balmas commented Jan 13, 2021

this is fixed in Alpheios Components 3.3.3-qa.20210113579

the code change was to consider a gerundive the same as a verb participle -- @monzug note that for now this change applies only to the treebank disambiguation and not the inflection matching.

There is also a corresponding change to the treebank data alpheios-project/alpheios-trees#15 to remove the incorrect tense

@monzug
Copy link
Contributor

monzug commented Jan 14, 2021

fugiendo (https://texts-test.alpheios.net/text/urn:cts:latinLit:phi0620.phi001.alpheios-text-lat1/passage/1.1) is only verb participle fut. pass. - the present form is gone

Screen Shot 2021-01-14 at 1 08 59 PM

@monzug monzug removed their assignment Jan 14, 2021
@balmas balmas reopened this Jan 15, 2021
@balmas balmas changed the title Latin verb with mood=gerundive matches whitaker pos = verb participle Latin verb with mood=gerundive matches whitaker mood=participle Jan 15, 2021
@balmas
Copy link
Member Author

balmas commented Jan 15, 2021

I went a little too far with this change, per #615

It's not actually that Whitaker reports the whole lexeme as being a verb participle when an inflection has the gerundive mood, but rather that the inflection itself has a part of speech which is verb participle but the lexeme itself is a verb. So I need to make this change a little less encompassing and more specific:

  1. a gerundive mood to match a participle mood.
  2. when retrieving the data from the treebank, set the pofs of the inflection of a gerundive to verb participle instead of verb

@balmas balmas removed the verified label Jan 15, 2021
balmas pushed a commit that referenced this issue Jan 15, 2021
and additional fixes for #608
don't trample on an inflections part of speech unnecessarily when
disamibugating inflections
@balmas
Copy link
Member Author

balmas commented Jan 18, 2021

@monzug please reverify in Alpheios Components 3.3.3-qa.20210115626 (changes for #615 directly impacted this fix)

@balmas balmas closed this as completed Jan 18, 2021
@monzug
Copy link
Contributor

monzug commented Jan 20, 2021

retested in Alpheios Embedded Library 3.3.1-20200821383
Alpheios Components 3.3.3-qa.20210119683 on Mac

@monzug monzug removed their assignment Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified
Projects
None yet
Development

No branches or pull requests

2 participants