Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font reference stored across frames #10

Open
cschol opened this issue Feb 26, 2022 · 2 comments
Open

Font reference stored across frames #10

cschol opened this issue Feb 26, 2022 · 2 comments

Comments

@cschol
Copy link

cschol commented Feb 26, 2022

The font reference is stored across frames, which crashes the plugin in the VST.

src/Psychtone.cpp
225-    std::shared_ptr<Font> font;
226-
227-    MyModuleDisplay() {
228:            font = APP->window->loadFont(asset::plugin(pluginInstance, "res/fonts/Sudo.ttf"));
229-    }
230-
231-    void draw(const DrawArgs &args) override {

See migration guide.

@alto777
Copy link
Owner

alto777 commented Feb 27, 2022

Indeed. I am sorry to have you spend that time. git and github played only a minor role, I own this stupid mistake.

Testing the fix now, THX.

a7

@alto777
Copy link
Owner

alto777 commented Feb 28, 2022

OK, with fingers crossed. Again, sry, I appreciate all the work you do for the amazing thing which is Rack.

FWIW I removed the font stuff after seeing, then remembering, it was part of an attempt to provide some debugging information and should have been removed.

I guess it is progress when I have errors that make me stretch my methods for finding them. :-|

a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants