Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why bluebird? #159

Open
jirutka opened this issue Apr 26, 2021 · 0 comments · May be fixed by #161
Open

Why bluebird? #159

jirutka opened this issue Apr 26, 2021 · 0 comments · May be fixed by #161

Comments

@jirutka
Copy link

jirutka commented Apr 26, 2021

Why do you still use Bluebird instead of native Promise?
jirutka added a commit to jirutka/url-to-pdf-api that referenced this issue Apr 26, 2021
@jirutka
Drop bluebird dependency, use native Promise
a3419ce 
Node.js provides native Promise API for more than six years. Node.js
versions older than that are unmaintained and unsupported for many
years. Thus Bluebird dependency is completely unnecessary.

Resolves alvarcarto#159
@jirutka jirutka linked a pull request Apr 26, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop bluebird dependency, use native Promise jirutka/url-to-pdf-api
1 participant
@jirutka