-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URIs to Images? #1
Comments
Google doesn't know either: I checked some of the file names, and they cannot be found:
|
We added the full URI to the data files a few days ago. Should be good to go now. let me know if there are any issues. |
I can't seem to find the full URI to artist images. Is it there in the data? |
@bsnikhila They are in https://github.com/american-art/SAAM/tree/master/WebObjectImages, aren't they? CC: @rkbrasse |
Ahhh, ARTIST images, very sorry...just re-read your thread... @rkbrasse it seems like we need an additional column in the CSV that puts in the full URI, can we get corrected Tuesday morning? |
The first row of
Second row:
|
I'll add this column ASAP. Should have it by 3pm EST. Will let you know when it is updated. |
Can anyone give me access to put the updated file in here? |
Rich, you can clone the repository, make the change to the file and then do a pull request. That way we know which file you have changed and then we can update the model.
… On Mar 3, 2017, at 8:39 AM, Rich ***@***.***> wrote:
Can anyone give me access to put the updated file in here?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABB-qT-rMSqnTXEwD1kAc4_e1tFCTfVhks5riEJKgaJpZM4JAqTq>.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/american-art/SAAM","title":"american-art/SAAM","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in ***@***.*** in #1: Can anyone give me access to put the updated file in here?"}],"action":{"name":"View Issue","url":"#1 (comment)"}}}
|
So I've cloned the repo, made the changes and I'm not allowed to create a pull request from my own branch or from master to master. |
Sorry, I gave you the wrong instructions. You have to fork the repo instead of cloning it. Then you will be able to do the pull request.
… On Mar 3, 2017, at 9:54 AM, Rich ***@***.***> wrote:
So I've cloned the repo, made the changes and I'm not allowed to create a pull request from my own branch or from master to master.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABB-qTW542_ZTFaPeFD6uky0xTPrJzweks5riFPpgaJpZM4JAqTq>.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/american-art/SAAM","title":"american-art/SAAM","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in ***@***.*** in #1: So I've cloned the repo, made the changes and I'm not allowed to create a pull request from my own branch or from master to master."}],"action":{"name":"View Issue","url":"#1 (comment)"}}}
|
Gotcha on it.
Rich Brassell
Web Developer at the Smithsonian American Art Museum
<http://americanart.si.edu/>
Work ph# 202-633-8579
Cell ph# 240-338-1923
On Fri, Mar 3, 2017 at 12:59 PM, Craig Knoblock <notifications@github.com>
wrote:
… Sorry, I gave you the wrong instructions. You have to fork the repo
instead of cloning it. Then you will be able to do the pull request.
> On Mar 3, 2017, at 9:54 AM, Rich ***@***.***> wrote:
>
> So I've cloned the repo, made the changes and I'm not allowed to create
a pull request from my own branch or from master to master.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub <
#1 (comment)>, or
mute the thread <https://github.com/notifications/unsubscribe-
auth/ABB-qTW542_ZTFaPeFD6uky0xTPrJzweks5riFPpgaJpZM4JAqTq>.
>
> {"api_version":"1.0","publisher":{"api_key":"
05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":
{"external_key":"github/american-art/SAAM","title":"
american-art/SAAM","subtitle":"GitHub repository","main_image_url":"
https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-
11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://
cloud.githubusercontent.com/assets/143418/15842166/
7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/american-art/SAAM"}},"
***@***.*** in #1: So
I've cloned the repo, made the changes and I'm not allowed to create a pull
request from my own branch or from master to master."}],"action":{"name":"View
Issue","url":"https://github.com/american-art/SAAM/issues/
1#issuecomment-284023795"}}}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABiqlY2YulY47x3YD5n71AltZuLmEc7rks5riFUYgaJpZM4JAqTq>
.
|
Done. Thanks for the help on logistics. Let me know if anything else is needed. |
Adding 2.americanart.si.edu to images.
There are filenames for the images of the objects in the data, but no (obvious) way to map those to URIs where the images are available. Is this possible?
The text was updated successfully, but these errors were encountered: