Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Saving p-values" never finishes with GNU Octave #18

Open
tobac opened this issue Apr 8, 2019 · 15 comments
Open

"Saving p-values" never finishes with GNU Octave #18

tobac opened this issue Apr 8, 2019 · 15 comments

Comments

@tobac
Copy link

tobac commented Apr 8, 2019

This issue seems to have been reported before (eg #10) but as it is closed I decided to open a new one.

I'm trying to run the following PALM analysis with GNU Octave on HCP subjects:

palm -i data_sub.nii -d design/design.mat -t design/design.con -o results_dense_subcortical -n 500 -corrcon -logp -accel tail -nouncorrected -T

palm -i data_L.func.gii -d design/design.mat -t design/design.con -o results_dense_cortical_L -T -tfce2D -s L_midthickness.surf.gii L_area.func.gii -logp -corrcon -nouncorrected -accel tail -n 500

palm -i data_R.func.gii -d design/design.mat -t design/design.con -o results_dense_cortical_R -T -tfce2D -s R_midthickness.surf.gii R_area.func.gii -logp -corrcon -nouncorrected -accel tail -n 500

I have used the exact same commands with Octave successfully before, but when adding more subjects to my analysis (80 vs. 247), Octave seems to get stuck in a loop or something. The last line to be output is the following:

Saving p-values (uncorrected, and corrected within modality and within contrast).

After that, nothing happens for days (!). Switching to MATLAB solves this problem (saving takes ~ 3 s). I'd rather use Octave, though.

The same thing happened to me before with a rather large number of study subjects.

@andersonwinkler
Copy link
Owner

Hi,
Thanks for letting me know. Which Octave version are you using and which operating system?
Also, may I ask if you could send me your files (input, design and contrast files)? You could place in some file-sharing service and send the link via email.
Thanks.
Anderson

@tobac
Copy link
Author

tobac commented Apr 8, 2019

GNU Octave, version 4.0.3 on Debian, i.e. the version provided in the Debian stable repository at the moment.

Email is on its way.

@tobac
Copy link
Author

tobac commented Apr 10, 2019

Update: This issue might indeed be fixed in more recent Octave versions. I set up an Arch Linux VM on our server in order to use the latest stable version et voilà: it works.

Working setup:
Running PALM alpha115 using Octave 5.1.0

@andersonwinkler
Copy link
Owner

Excellent!

@tobac
Copy link
Author

tobac commented Jun 21, 2019

I'm afraid I'm facing the same issue with regard to another analysis I'm trying to run. This time, both Octave and MATLAB won't finish saving.

I'd be happy to send you the input files.

@tobac
Copy link
Author

tobac commented Jun 22, 2019

When using MATLAB, trying to kill the process will output the function and line number at which the script hangs (presumably), so this might be helpful:

Computing p-values.
Saving p-values (uncorrected, and corrected within modality and within contrast).
Operation terminated by user during palm_pareto (line 116)


In palm_saveall (line 246)
                        Ptosave =
                        palm_pareto(plm.G{y}{m}{c},plm.Gmax{y}{m}{c},false,opts.accel.tail_thr,opts.accel.G1out);

In palm_core (line 2489)
palm_saveall(plm,opts);

In palm (line 81)
palm_core(varargin{:});

@andersonwinkler
Copy link
Owner

Hi @tobac,

Yes, if you could send the input files I'd be happy to have a look. Use any file sharing service then send me the link. I'm reluctant to paste my email here because of bots; you may be able to find it easily, though (e.g., in the FSL mailing list, or in the Yale or NIH directories).

All the best,

Anderson

@tobac
Copy link
Author

tobac commented Jun 26, 2019

Hi @andersonwinkler,

did you get the email I sent to your Gmail address two days ago?

@andersonwinkler
Copy link
Owner

I did! But I couldn't reply yet (I can no longer keep up with emails, some always fall through the cracks...; please give me a few days).

In any case, the message indicates the process was killed by the user. Could it be that you hit some wall time or memory limits?

@ashlea-segal
Copy link

I am experiencing the same problem with PALM alpha116 MATLAB r2019b.
I am trying to run the following PALM analysis on HCP subjects as well:

palm -i data_sub.nii -o results_dense_subcortical -n 10000 -corrcon -logp -accel tail -nouncorrected -T

It seems to get stuck at the same point @tobac mentioned above:

Saving p-values (uncorrected, and corrected within modality and within contrast).

Did you find a solution to this issue?

Thank you in advance,
Ashlea

@andersonwinkler
Copy link
Owner

andersonwinkler commented Nov 9, 2020 via email

@ashlea-segal
Copy link

Thank you for your prompt reply, @andersonwinkler!

I tried the current version on Github and a different seed, neither worked, however the gamma approximation ran but the fwep results were NaNs. Following your suggesting on the HCP mailing list (here), I included the -precision double flag, both approximation methods worked. The results however, vary in significance. Using the gamma approximation, there is a range of significant values (1-6), whereas using the tail approximation, a high majority of significant values are 4 (logp).

@andersonwinkler
Copy link
Owner

andersonwinkler commented Nov 10, 2020 via email

@ashlea-segal
Copy link

ashlea-segal commented Nov 13, 2020 via email

@JAQuent
Copy link

JAQuent commented May 11, 2024

I am using pal, Jun/2021 (version alpha119) and Matlab both on a computing cluster as well as locally on my computer running Ubuntu and I have the same issue (stuck at "Computing p-values.") when attempting a resting-state connectivity analysis on HCP-style data.

palm -i Y.dscalar.nii -transposedata -d design_matrix.csv -t contrast.csv -ise -o "results_${ROI_NAME}" -n 5000 -corrcon -logp -accel tail -fdr -zstat -ise -precision double

Adding the -precision flag does seem to solve the issue but I will keep you updated if it crops up again. Interestingly, four other (larger) ROIs don't have this issue only the two smallest. Is it possible that the two smaller ROIs that I use create a problem because the correlation with itself is so high? Would it make sense to exclude these voxels/vertices?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants