Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

who_pumpkin misnomer #535

Open
ap opened this issue Aug 2, 2024 · 2 comments
Open

who_pumpkin misnomer #535

ap opened this issue Aug 2, 2024 · 2 comments

Comments

@ap
Copy link
Contributor

ap commented Aug 2, 2024

Arguably this action should have been called who_pumpking (note the “g”) at the end (see “pumpkin” vs “pumpking” in perlglossary).

It is probably not a worthwhile use of time to fix the URL now, and we should just retcon “who_pumpkin” as meaning “who has held the pumpkin“, but the nav menu item and page heading should still say “List of pumpkings” and the list “Registered pumpkings”.

@haarg
Copy link

haarg commented Oct 2, 2024

As noted on #534, the pumpking role has been retired, so we'd want a new term for this. Probably just something explanatory like "Authorized Perl releasers".

@ap
Copy link
Contributor Author

ap commented Dec 1, 2024

I was hoping that all the user-facing uses referred only to “pumpkin”, not “pumpking”, in which case we could at least stop talking about “pumpkings” and just refer to the “pumpkin bit”. That would allow a minimal patch that would take into account the stated intent.

Unfortunately the respective file is called 08pumpkings.txt.gz, so the term has slipped out in a user-facing way that we cannot easily fix. And there are a hundred more places in the code which refer to either “pumpkin” or “pumpking”, including a DB column name and a user group name.

I’m not personally interested in cleaning all of that up. I am bothered by the mistaken usage, and given that a wholesale terminology switch is a lot of work, I intend to just fix the one mistake while leaving the current terminology in place.

If anyone else is motivated enough to take on the wholesale terminology switch, I’m happy for them to do so. It just won’t be me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants