-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull to refresh doesn't work when there are no tasks #916
Comments
@dturner @manuelvicnt @tunjid Please take a look and review this PR #934. Thank you |
Sorry for the delay. Please fix the spotless formatting on the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to repro:
Expected outcome
Actual outcome
Further details:
Pull to refresh is implemented in the
LoadingContent
composable. This either displays empty content or if it is non empty (specified by the logictasks.isEmpty() && !loading
) a container which supports pull to refresh.So the problem is that the empty content should be displayed inside a container which supports pull to refresh.
Additionally the code is currently using
SwipeRefresh
from the accompanist library which is deprecated and needs migrating https://google.github.io/accompanist/swiperefresh/#migrationThe text was updated successfully, but these errors were encountered: