Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work since around 5. Nov 2017 on PHPStorm anymore #9

Closed
cclsn opened this issue Dec 6, 2017 · 7 comments
Closed

Does not work since around 5. Nov 2017 on PHPStorm anymore #9

cclsn opened this issue Dec 6, 2017 · 7 comments

Comments

@cclsn
Copy link

cclsn commented Dec 6, 2017

We were successfully using wslgit, but around 5.11. it stopped working.
Then on 8. Nov we found the new release and installed it - still not working.

When we do git actions, four Command Line processes appear in the task manager which consume lots of resources.

How can this problem be trouble shooted?

@cclsn
Copy link
Author

cclsn commented Dec 6, 2017

taskmanager

@cclsn
Copy link
Author

cclsn commented Dec 6, 2017

We checked the PHPstorm log and saw that the following is executed:

"C:\Program Files\JetBrains\PhpStorm 2017.2.3\bin\runnerw.exe" C:\Windows\git.exe ....

when executing

"C:\Program Files\JetBrains\PhpStorm 2017.2.3\bin\runnerw.exe" C:\Windows\git.exe in CMD, it also seems to hang - to the problem does not seem to be directly related to PHPstorm

@andy-5
Copy link
Owner

andy-5 commented Dec 7, 2017

This is a known bug in WSL since the Fall Creators Update, see microsoft/WSL#2592

Aparently, it is already fixed in the Insider Builds of Windows, but there is no general update available.

The latest wslgit Release (v0.3.0) fixes this for VS Code by special casing the call to git --version, which seems to be the only affected command in the case of VS Code.

However, I suspect that in your case all commands are affected, because they are all performed through the same runnerw.exe executable. Or do other commands maybe show a different behaviour? Does something like

"C:\Program Files\JetBrains\PhpStorm 2017.2.3\bin\runnerw.exe" C:\Windows\git.exe status

also hang?

Also, the runnerw.exe executable seems to have a /C command line switch to open a new, visible, console. Maybe this could be a workaround? Could you please try this:

"C:\Program Files\JetBrains\PhpStorm 2017.2.3\bin\runnerw.exe" /C C:\Windows\git.exe

@andy-5
Copy link
Owner

andy-5 commented May 2, 2018

With the Windows 10 April 2018 Update now available and several new releases of wslgit, could you maybe test if this is still an issue?

@n0l0cale
Copy link

hi all,

exactly the same issue with Android Studio. AS claims that git.exe would not work as expected and the processes bash and git remains up to the next reboot. (4 tries to run git each time I start android studio).

a minidump of the file does not contain any exception code.... Maybe some kind of logging would be useful? (startparamters?)

Cheers,
S.

P.S.: Windows Version 1803 (17134.48) with all available updates installed

@andy-5
Copy link
Owner

andy-5 commented May 30, 2018

Thanks for the update. It seems the latest Windows release did not fix the hanging processes, as I hoped.

Could you try setting the Windows environment variable WSLGIT_USE_INTERACTIVE_SHELL to false (see Readme for more information on that) and check if this changes anything?

Yes, logging would be possible, but it can noticeable slow down execution. I'll look into adding it optionally, or maybe provide a separate executable for testing.

@andy-5
Copy link
Owner

andy-5 commented Sep 17, 2018

Recent issue #41 suggests that wslgit generally works with IntelliJ now, so I'm closing this issue.

Feel free to respond here or open a new issue if you still have any problems.

@andy-5 andy-5 closed this as completed Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants