Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have green color as "100% strong password" #162

Closed
andreElrico opened this issue Apr 16, 2019 · 8 comments
Closed

Have green color as "100% strong password" #162

andreElrico opened this issue Apr 16, 2019 · 8 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed PR WELCOME <3 Pull Requests are welcome with love <3

Comments

@andreElrico
Copy link

I understand the design of returning the primary color here. However my primary color is not green.
How can I make the "primary color" green? This is probably a material flaw by not having a success color.

I solved this problem by adding global styles css:

mat-password-strength mat-progress-bar.mat-progress-bar.mat-primary > div.mat-progress-bar-primary.mat-progress-bar-fill.mat-progress-bar-element::after {
    background-color: #155724;
}

mat-password-strength mat-progress-bar.mat-progress-bar.mat-primary > div.mat-progress-bar-secondary.mat-progress-bar-fill.mat-progress-bar-element::after {
    background-color: #155724;
}

mat-password-strength-info > mat-card  > mat-card-content > div.info-row > mat-icon.mat-icon.mat-primary {
    color: #155724;
}

Is there a way or any plans on making a API that styles a 100% save password green?

Something like

@Input() savePasswordGreen: boolean

Best wishes,
André

@AnthonyNahas AnthonyNahas self-assigned this Apr 16, 2019
@AnthonyNahas AnthonyNahas added the enhancement New feature or request label Apr 16, 2019
@AnthonyNahas
Copy link
Member

Currently, we are only supporting the native colors of the material palette that has been selected. I can understand that a completely valid password should has a green color. I will take this feature in consideration for the next release!

Thanks for suggesting that 🍻

@AnthonyNahas AnthonyNahas added the PR WELCOME <3 Pull Requests are welcome with love <3 label Apr 24, 2019
@AnthonyNahas
Copy link
Member

AnthonyNahas commented Apr 24, 2019

@andreElrico this has been solved 👍
The new version will be released soon

@AnthonyNahas
Copy link
Member

@andreElrico I've just implemented this feature 🎉

I will publish in few minutes v3.8.0

To use always the green color for a strong password.. just add the green css class to
the mat-password-strength like the following example:

<mat-password-strength #passwordComponent
                       class="green"
                       [password]="password.value">
</mat-password-strength>

Thanks again for requesting this feature, this could be interesting to integration in ngx-auth-firebaseui

cheers 🍻

@AnthonyNahas
Copy link
Member

v3.8.0 is now live 👍

@crismani
Copy link

@AnthonyNahas This isn’t working in 4.0.1 has anything changed?

Thanks in advance for your help.

@bleuscyther
Copy link

Not working anymore

@AnthonyNahas
Copy link
Member

I've just updated the angular and material dependencies ...

@AnthonyNahas AnthonyNahas reopened this Nov 3, 2019
@AnthonyNahas
Copy link
Member

AnthonyNahas commented Nov 3, 2019

I have tried to fix that.. apparently the angular material team change some css classes related to the material progress bar..

I think, I need some help asap to fix that 💯 Please feel free to pull a new request for changes

thank you 🍻

@AnthonyNahas AnthonyNahas added bug Something isn't working help wanted Extra attention is needed PR WELCOME <3 Pull Requests are welcome with love <3 and removed ready enhancement New feature or request labels Nov 3, 2019
@AnthonyNahas AnthonyNahas reopened this Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed PR WELCOME <3 Pull Requests are welcome with love <3
Projects
None yet
Development

No branches or pull requests

4 participants