Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 17 support #407

Open
guillaume-moreau opened this issue Mar 7, 2024 · 16 comments
Open

Angular 17 support #407

guillaume-moreau opened this issue Mar 7, 2024 · 16 comments

Comments

@guillaume-moreau
Copy link

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request

OS and Version?

Versions

Repro steps

ng update @angular/core@17 @angular/cli@17

The log given by the failure

npm ERR! Could not resolve dependency:
npm ERR! peer @angular/cdk@"^16.x" from @angular-material-extensions/password-strength@16.0.0
npm ERR! node_modules/@angular-material-extensions/password-strength
npm ERR!   @angular-material-extensions/password-strength@"16.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!

Mention any other details that might be useful

If needed I can provide a pull request.

Thank you :)

@jruizperalvo
Copy link

jruizperalvo commented Mar 8, 2024

I have the same problem in angular 17. I had to use npm install --force to skip this errors but personally i dont like this.
I',m watching to downgrade my app to angular 16 to solve it.

@Barrier-Theo
Copy link

@AnthonyNahas Hi, Is there any plan to upgrade to angular 17 ?

@jbellionjourdan
Copy link

jbellionjourdan commented Apr 17, 2024

The lib works fine for me on angular 17 by forcing the dependency installation with '--force'.
Tried sending an email to the lib owner a while ago, with no results unfortunately.

EDIT: looks like there was a commit last month upgrading part of the project to angular 17. So it looks like it'd be WIP.

@guillaume-moreau
Copy link
Author

The lib works fine for me on angular 17 by forcing the dependency installation with '--force'. Tried sending an email to the lib owner a while ago, with no results unfortunately.

EDIT: looks like there was a commit last month upgrading part of the project to angular 17. So it looks like it'd be WIP.

Yup, but I would like to avoid using --force if possible.

@203876149
Copy link

There is any news?
I can't update my app until this will be resolve.

@carlokid
Copy link

Waiting for the update as well

@adamnik101
Copy link

Still waiting...

@sergi884
Copy link

I have been waiting for these updates for a few months.
Hey team, when can we estimate this update?

@spbuda
Copy link

spbuda commented Jun 4, 2024

I know things are never trivial, but since this is backwards compatible, shouldn't an update to the package.js file be all this needs? Even if there are improvements that someone wants to make, waiting like this can't be the best solution.

@carlokid
Copy link

carlokid commented Aug 9, 2024

Just a friendly nudge. Anyone here resorted to switch to an actively maintained alternative?

@guillaume-moreau
Copy link
Author

On our side we remade our own password strength component :/ (we got a simple use case it was not a big amount of work)

@spbuda
Copy link

spbuda commented Aug 9, 2024

We've been using the --force flag, but intend to roll our own if we ever find the time. Don't have a lot of faith in this project promptly updating for future updates, even if the dev does finish this one.

@jbellionjourdan
Copy link

I might be willing to take over this lib and provide support for it, but it'd be my first published library so i need some time to figure out how it works.

I might have time in september, but no promises there.

@AnthonyNahas
Copy link
Member

Ill upgrade to v17 soon

@MPalix86
Copy link

waiting

@spbuda
Copy link

spbuda commented Oct 3, 2024

soon™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests