Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from Travis CI to Github Actions #1221

Open
eltonmesquita opened this issue Jan 18, 2021 · 18 comments
Open

Move from Travis CI to Github Actions #1221

eltonmesquita opened this issue Jan 18, 2021 · 18 comments

Comments

@eltonmesquita
Copy link
Collaborator

Our CI settings are a bit outdated - they just npm install - we should move them to Github actions so the whole team can have full access to the whole process. It should run:

  • npm install
  • npm start
  • npm run docs
@AtharvaParkale
Copy link

I think this link may solve your problem.
https://developer.okta.com/blog/2020/05/18/travis-ci-to-github-actions

@eltonmesquita
Copy link
Collaborator Author

Thanks for the link. If you have some free time and fancy put a PR together for this it'd be amazing!

@AtharvaParkale
Copy link

I am a newbie, so am not sure what to do..

@eltonmesquita
Copy link
Collaborator Author

eltonmesquita commented Jan 26, 2021

No worries @AtharvaParkale. But if you feel like trying it will be very helpful, and you'll get to learn a few things in the way. Be sure that we would be very supportive of your PR (but maybe a bit slow to review it 😅).

@warengonzaga
Copy link
Member

I think this link may solve your problem.
https://developer.okta.com/blog/2020/05/18/travis-ci-to-github-actions

I guess I can give it a try?

@eltonmesquita
Copy link
Collaborator Author

Sure, feel free to do it @warengonzaga .

@eltonmesquita
Copy link
Collaborator Author

We should probably add some linting on the process too as it's common that some small mistakes pass through our code reviews. I'll think about what's the best approach for this as we want to keep it as simple as possible.

@YashBhambhani12345
Copy link

Hello,my name is Yash Bhambhani. I am new to github. I want to contribute to your project.I have knowledge about css and html.
Please guide me how to go about it

@warengonzaga
Copy link
Member

Hello,my name is Yash Bhambhani. I am new to github. I want to contribute to your project.I have knowledge about css and html.
Please guide me how to go about it

Hi do you have experience on gitflow?

@warengonzaga
Copy link
Member

We should probably add some linting on the process too as it's common that some small mistakes pass through our code reviews. I'll think about what's the best approach for this as we want to keep it as simple as possible.

Sure thing will check it out... I guess I can make simple at first since I don't have real experience with workflows.

@yogeshtiwari24
Copy link

Hello, I am a newbie looking for someone to guide me to be a contributor in Github can anyone help me?

@genzarchitect
Copy link

#1273

@warengonzaga
Copy link
Member

Thanks @shamonhashmi for the PR we'll check it out.

@animate-css animate-css deleted a comment from genzarchitect Jul 18, 2021
@warengonzaga
Copy link
Member

Hello, I am a newbie looking for someone to guide me to be a contributor in Github can anyone help me?

if you are looking for repo that needs help you can check my other open-source.

@shanmuganathan-balaraman
Copy link

shanmuganathan-balaraman commented Sep 2, 2022

@eltonmesquita @warengonzaga is this still open? anyone is working on it?

@warengonzaga
Copy link
Member

@eltonmesquita @warengonzaga is this still open? anyone is working on it?

hey there, yes valid you can submit your PR.

@shanmuganathan-balaraman
Copy link

shanmuganathan-balaraman commented Sep 5, 2022

@eltonmesquita @warengonzaga is this still open? anyone is working on it?

hey there, yes valid you can submit your PR.

What is the expectation? Do we need to simply run npm start and docs in GitHub actions and check for build failures or do we need to build and commit the output it the same branch when a PR is created?

@eltonmesquita @warengonzaga

@kr1st1nagr03g3r
Copy link

I have a PR for you. I see this is a little stale so may as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants