Implement allowlist and blocklist #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarHarLinks
requested changes
Dec 26, 2023
|
I will now test the implementation more thoroughly and remove the WIP tag when I'm done testing. |
|
(CI failing on python 3.12 is expected: #112) |
svierne
changed the title
|
Seems to be working as expected. Good to merge from my side. (: |
HarHarLinks
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements both allowlisting and blocklisting regexes of MXIDs.
I have not completely tested these changes yet, this is still a draft version to allow the maintainers to do an initial review and request changes before I do final testing.
@HarHarLinks What do you think? I'm still thinking about whether or not the bot should respond with an error message when receiving a message from a disallowed user. Especially with open issues of the bot spamming duplicate responses to old messages, I personally think we should just drop the events without any response. But this may be bad UX for accidentally disallowed users.